🐛 Fix recordings, do not store assets if they do not have an MRN or an id#5935
Merged
preslavgerchev merged 1 commit intomainfrom Sep 19, 2025
Merged
🐛 Fix recordings, do not store assets if they do not have an MRN or an id#5935preslavgerchev merged 1 commit intomainfrom
preslavgerchev merged 1 commit intomainfrom
Conversation
c34ee9b to
9ae8124
Compare
Contributor
9ae8124 to
1e89bed
Compare
…n id. Signed-off-by: Preslav <preslav@mondoo.com>
1e89bed to
90c3174
Compare
vjeffrey
approved these changes
Sep 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
runtime.AssetUpdatedgets called when we update the asset's MRN. Recordings that get sent upstream are only retrieved by MRN so we need to ensure that every time the MRN gets updated we need to update the recordingTo test, first run
make cnquery/install, then run this qp:Then load the recording:
Accessing
packages,usersandservicesshould be instant